Simplify some code with slices and for-range.#1237
Open
atombrella wants to merge 1 commit intocontainernetworking:mainfrom
Open
Simplify some code with slices and for-range.#1237atombrella wants to merge 1 commit intocontainernetworking:mainfrom
atombrella wants to merge 1 commit intocontainernetworking:mainfrom
Conversation
atombrella
force-pushed
the
feature/modernize_update
branch
2 times, most recently
from
afa7a75 to
2d7d599
Compare
Contributor
Author
|
@s1061123 Care to have a look? I could enable the |
Contributor
|
I don't have so much time these days, hence I recommend to find another guy to review... |
Contributor
|
In addition, this PR and your another one seems to be 'golang syntax improvement to modern', hence the priority looks lower than other serious one (such as bug fix and security one and so on). |
Member
|
@atombrella this looks good to me. Can you rebase without a merge commit and we can merge this? |
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
atombrella
force-pushed
the
feature/modernize_update
branch
from
708642f to
1712038
Compare
Contributor
Author
@squeed Rebased 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied a few of the modernize rules to simplify the code slightly:
slices.Contains// +buildwhich definitely needs to go.slices.Sortinstead ofsort.Slice.The golangci-lint version is a bit old, and I didn't want to tamper around with it in this PR.