Remove redefinitions of loop variables in for-loops.#1240
Open
atombrella wants to merge 1 commit intocontainernetworking:mainfrom
Open
Remove redefinitions of loop variables in for-loops.#1240atombrella wants to merge 1 commit intocontainernetworking:mainfrom
atombrella wants to merge 1 commit intocontainernetworking:mainfrom
Conversation
atombrella
force-pushed
the
feature/modernize_forvar
branch
from
417acad to
776e606
Compare
e0ne
approved these changes
Mar 31, 2026
Contributor
e0ne
left a comment
e0ne
left a comment
There was a problem hiding this comment.
LGTM. Thanks for cleaning this up!
squeed
requested changes
Apr 13, 2026
Member
squeed
left a comment
squeed
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Can you please rebase and remove the merge commits? Then we can land this.
This pattern was made obsolete with the GoLang 1.22 semantics for the for-loop. Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
atombrella
force-pushed
the
feature/modernize_forvar
branch
from
c863bc2 to
e848979
Compare
Contributor
Author
@squeed Rebased 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pattern was made obsolete with the GoLang 1.22 semantics for the for-loop.
I have opened an issue to get the ginkgo documentation updated.