Add "BaseTLS" options #623
Draft
+913
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
common
aguidirh
reviewed
Feb 4, 2026
aguidirh
left a comment
aguidirh
left a comment
There was a problem hiding this comment.
Even with limited knowledge about the library, I tried my best to give my contribution o the code review.
common/pkg/download/download.go
Outdated
| // empty). | ||
| func FromURL(ctx context.Context, tmpdir, source string) (string, error) { | ||
| // If baseTLSConfig is not nil, it may contain TLS _algorithm_ options (e.g. TLS version, cipher suites, “curves”, etc.). | ||
| func FromURL(ctx context.Context, tmpdir, source string, baseTLSConfig *tls.Config) (string, error) { |
There was a problem hiding this comment.
Is this API used only internally? I'm asking because it is a breaking API change so I'm not sure the impact of it.
There was a problem hiding this comment.
How about extending the API by passing a struct and adding types on that struct? It could reduce frictio in future if the API needs to be extended again.
Contributor
Author
There was a problem hiding this comment.
c/common does not have a stable API commitment [and forcing callers to update means less risk of overlooking that we have to do something].
Using a struct here does make sense, I’ll update the PR.
Comment on lines
-33
to
-37
| // We have already done this parsing in ParseReference, but thrown away | ||
| // httpClient. So, parse again. | ||
| // (We could also rework/split restClientFor to "get base URL" to be done | ||
| // in ParseReference, and "get httpClient" to be done here. But until/unless | ||
| // we support non-default clusters, this is good enough.) |
There was a problem hiding this comment.
Nice to see we are also maintaining the comments and not only the code. This is something rare, thanks!
|
Packit jobs failed. @containers/packit-build please check. |
Contributor
Author
|
Extended to also cover c/common/libimage. Fulcio + the related OIDC workflows are missing — we might need to change the clients upstream, or replace them. Other than that, this should be comprehensive for container-libs.
|
Contributor
Author
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Feb 7, 2026
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
6 tasks
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Feb 7, 2026
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
tls-behavior
branch
2 times, most recently
from
1d90952 to
b4a2bcd
Compare
The "parsing again" was removed in commit 35256ec . Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There's really no benefit to it. Should not change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will replace the implementation Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The underlying implementation is there, but it is not exposed in the API; we need an implementation for Fulcio + OIDC as well, and then we should decide whether the two get separate BaseTLS options, or whether we will do signature/sigstore.WithBaseTLS that applies to both. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
- Use a context to allow aborting, instead of silencing a relevant lint warning - Use a separate http.Client so that we don't share cookies with the rest of the process Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... and allow configuring BaseTLS. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It has no real users (one caller in Podman hard-codes it to nil), and it's unclear how it interacts with RuntimeOptions.SystemContext. Instead, it might make more sense to add more specific override options to CopyOptions, falling back on the runtime's SystemContext if unset. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Minimal manual tests, using containers/skopeo#2797 : % cat tls-details-pqc-only.yaml
minVersion: "1.3"
namedGroups:
- "X25519MLKEM768"
# docker:
% bin/skopeo --tls-details ./tls-details-pqc-only.yaml inspect --raw docker://quay.io/foo
FATA[0000] Error parsing image name "docker://quay.io/foo": pinging container registry quay.io: Get "https://quay.io/v2/": EOF
# oci:
# manually prepared image, with manifest
% cat oci-layout/blobs/sha256/8083ab158310d4a23b04ff72f5485fe913c457e033811c159e4314f095492378
{
"schemaVersion": 2,
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"config": {
"mediaType": "application/vnd.oci.image.config.v1+json",
"digest": "sha256:31003e2979e8f5fec9358644591ce51df452fb489624bd09a999f2d6e091e936",
"size": 604
},
"layers": [
{
"mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
"digest": "sha256:161a397ac5ee9e631cd79cdfb5f0b36a861071d42e67afe98ed3cb69155ea5ff",
"size": 2776947,
"urls": ["https://quay.io/v2/"]
}
]
}
% bin/skopeo --insecure-policy --tls-details ./tls-details-pqc-only.yaml copy oci:oci-layout dir:t2
Getting image source signatures
Copying blob 161a397ac5ee [--------------------------------------] 0.0b / 2.6MiB | 0.0 b/s
FATA[0000] reading blob sha256:161a397ac5ee9e631cd79cdfb5f0b36a861071d42e67afe98ed3cb69155ea5ff: fetching "https://quay.io/v2/" failed Get "https://quay.io/v2/": EOF: failed fetching external blob from all urls
# atomic:
% KUBERNETES_MASTER=https://quay.io/ bin/skopeo --tls-details ./tls-details-pqc-only.yaml inspect --raw atomic:quay.io:443/foo/bar:baz
FATA[0000] Error retrieving manifest for image: Get "https://quay.io/oapi/v1/namespaces/foo/imagestreams/bar": EOF
# docker-daemon:
% bin/skopeo --tls-details ./tls-details-pqc-only.yaml inspect --daemon-host=https://quay.io --raw docker-daemon:foo:bar
FATA[0000] Error parsing image name "docker-daemon:foo:bar": loading image from docker engine: error during connect: Get "https://quay.io/v1.53/images/get?names=foo%3Abar": EOF Untested: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now absolutely untested, andwith Rekor+Fulcio not configurable.On top of #619.