Skip to content

storage: use maps.Equal for comparing file xattrs #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
caxu-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

storage: use maps.Equal for comparing file xattrs #645

caxu-rh wants to merge 1 commit into from

Conversation

@caxu-rh
Copy link
Contributor

@caxu-rh caxu-rh commented Feb 9, 2026

maps.Equal() is available in Go 1.21+ when comparing maps whose key and value types satisfy comparable (including string), and is generally more performant than reflect.DeepEqual.

@caxu-rh
storage: use maps.Equal for comparing file xattrs
dd647a6 
Signed-off-by: Caleb Xu <caxu@redhat.com>
@github-actions github-actions bot added the storage Related to "storage" package label Feb 9, 2026
mtrmac
mtrmac approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees

No one assigned

Labels

storage Related to "storage" package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caxu-rh @mtrmac