core: add support for Oras(-py) as a 3rd backend#164
core: add support for Oras(-py) as a 3rd backend#164tarilabs merged 4 commits intocontainers:mainfrom
Conversation
tarilabs
force-pushed
the
tarilabs-20260312
branch
2 times, most recently
from
3cb3037 to
59e07bb
Compare
in addition to existing Skopeo, Oras (Go CP) Signed-off-by: tarilabs <matteo.mortari@gmail.com>
tarilabs
force-pushed
the
tarilabs-20260312
branch
from
59e07bb to
5940d86
Compare
jonburdo
left a comment
jonburdo
left a comment
There was a problem hiding this comment.
lgtm! I didn't get to go through every detail, but makes sense overall. I mentioned one issue I ran into with auth.
I wonder if in the future we'd want to have some parametrized tests that do the exact same thing with oras and with oras-py since they should behave pretty much the same.
| registry = Registry(insecure=insecure, tls_verify=tls_verify) | ||
| _setup_auth(registry, oci_ref) | ||
| layout = NewLayout(src) | ||
| layout.push_to_registry(provider=registry, target=oci_ref, tag="latest") |
There was a problem hiding this comment.
I ran into an issue testing this on quay.io
A combination of manual testing and trying to debug with claude resulted in this: tarilabs#1
(not trying to merge that just for info in case anything there is useful)
Seems it's an upstream oras-py issue and I think different registries have different quirks, so it may not be something to address here, but I wanted to share what I ran into.
There was a problem hiding this comment.
Seems I just needed to make sure I was creating an empty repo first: tarilabs#1 (comment)
Sorry for the confusion 😬 😆
There was a problem hiding this comment.
thank you for the extra care
tarilabs
force-pushed
the
tarilabs-20260312
branch
2 times, most recently
from
76510e1 to
63e4f1c
Compare
Co-authored-by: Jon Burdo <jon@jonburdo.com> Signed-off-by: tarilabs <matteo.mortari@gmail.com>
tarilabs
force-pushed
the
tarilabs-20260312
branch
from
63e4f1c to
4c4737e
Compare
Co-authored-by: Jon Burdo <jon@jonburdo.com> Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
jonburdo
left a comment
jonburdo
left a comment
There was a problem hiding this comment.
Looks great! Confirmed with the small test script
indeed which is incorporated with attribution in this PR 👍 I'm going to merge this. |
2 participants
in addition to existing Skopeo, Oras (Go CP)