Skip to content

fix(sap-commerce-cloud): skip prepending apiEndpoint for absolute image URLs #10672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mihai (Mihai-Sprinceana) wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(sap-commerce-cloud): skip prepending apiEndpoint for absolute image URLs #10672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f123936
fix(sap-commerce-cloud): skip prepending apiEndpoint for absolute ima…
Mihai-Sprinceana Mar 5, 2026
812bbf8
Merge branch 'master' into fix/sap-image-url-domain
Mihai-Sprinceana Apr 1, 2026
61767d4
Merge branch 'master' into fix/sap-image-url-domain
Mihai-Sprinceana Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/sap-commerce-cloud/frontend/src/api/dataTransformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const productTransformer =
(item: Hash): Product => {
const id = get(item, ['id'], '');
let imageUrl = get(item, ['images', 0, 'url'], '');
if (imageUrl.length > 0) {
if (imageUrl.length > 0 && !imageUrl.startsWith('http://') && !imageUrl.startsWith('https://')) {
imageUrl = apiEndpoint + imageUrl;
}
Comment on lines +13 to 15
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior (skipping apiEndpoint prefix when imageUrl is absolute) isn’t covered by unit tests. Please add cases asserting that relative URLs (e.g. "/media/123") are prefixed and absolute URLs (e.g. "https://static.test.com/media/123") are left unchanged.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@Mihai-Sprinceana Mihai (Mihai-Sprinceana) Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot apply changes based on this feedback

const sku = get(item, ['code'], '');
Expand Down Expand Up @@ -42,7 +42,7 @@ export const productDetailsTransformer =
(item: Hash): Product => {
const id = get(item, ['id'], '');
let imageUrl = get(item, ['images', 0, 'url'], '');
if (imageUrl.length > 0) {
if (imageUrl.length > 0 && !imageUrl.startsWith('http://') && !imageUrl.startsWith('https://')) {
imageUrl = apiEndpoint + imageUrl;
}
Comment on lines +45 to 47
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updated absolute-vs-relative URL guard in productDetailsTransformer should be exercised in tests as well (relative image URL gets prefixed; absolute image URL passes through) to prevent regressions.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@Mihai-Sprinceana Mihai (Mihai-Sprinceana) Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot apply changes based on this feedback

return {
Expand Down