Redirect: Adding metrics section [MAPS-237]#10673
Open
Franco Banfi (FBanfi) wants to merge 3 commits intoredirect-maps-236from
Open
Redirect: Adding metrics section [MAPS-237]#10673Franco Banfi (FBanfi) wants to merge 3 commits intoredirect-maps-236from
Franco Banfi (FBanfi) wants to merge 3 commits intoredirect-maps-236from
Conversation
Collaborator
Joaquin (joaquincasal)
left a comment
Joaquin (joaquincasal)
left a comment
There was a problem hiding this comment.
Looks good! Left one small comment
Comment on lines
+51
to
+56
| { label: 'Total Redirects', value: allRedirects.length }, | ||
| { label: 'Active Redirects', value: active }, | ||
| { label: 'Inactive Redirects', value: inactive }, | ||
| { label: "Vanity URL's", value: vanityUrls.length ?? '—' }, | ||
| { label: '301 Permanent', value: permanent }, | ||
| { label: '302 Temporary', value: temporary }, |
Collaborator
There was a problem hiding this comment.
The labels shoud be sentance case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This update includes the metric section.
Approach
Testing steps
Automated tests added.
Grabacion.de.pantalla.2026-03-05.a.la.s.11.24.03.a.m.mov
Breaking Changes
N/A
Dependencies and/or References
Link to MAPS-237
Deployment
N/A