improve: add cancelled tool messages

[uinstinct]

Description

For dangling tool calls in normal messages, add cancelled messages in chat history.

closes CON-5280

AI Code Review

• Team members only: AI review runs automatically when PR is opened or marked ready for review
• Team members can also trigger a review by commenting @continue-review

Checklist

• [] I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

---

Continue Tasks: ▶️ 2 queued — View all

---

Summary by cubic

Adds “Tool cancelled” messages to the chat when an assistant tool call has no matching result. Prevents dangling tool calls and keeps history consistent (CON-5280).

• Bug Fixes
  • Track toolCallIds with results from tool messages and toolCallStates.
  • Insert a “Tool cancelled” tool message for any assistant toolCall without a result.
  • Applies to normal messages to remove dangling tool call entries.

^{Written for commit 5e5f5b9. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 1 file

[RomneyDa]

@uinstinct constructMessages already defaults to a NO_TOOL_CALL_OUTPUT_MESSAGE case for any toolCallState without tool output. Could you check why this isn't working? It seems like maybe toolCalls and toolCallStates are getting out of sync?

[RomneyDa]

remove console.log

[uinstinct]

@uinstinct constructMessages already defaults to a NO_TOOL_CALL_OUTPUT_MESSAGE case for any toolCallState without tool output. Could you check why this isn't working? It seems like maybe toolCalls and toolCallStates are getting out of sync?

Should have checked this one before putting up the PR - had initially thought there might be problem in parallel tool calls so went ahead with resolution before checking the cause.

Checked and found out that cancelled tool messages are present for both normal and parallel tool calls. Compaction also works due to the earlier pr

closing this PR

[RomneyDa]

yeah I wonder if we're just a bit behind on releases and still getting issues from old versions. I'll try to get releases out this week.