-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(cli): add cn config command for model management #9960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de2252b
fix(cli): correct env priority in CLIPlatformClient
aaronlippold cc1c3aa
feat(cli): add cn config core functions
aaronlippold 30ed584
feat(cli): add cn config command handlers
aaronlippold 2e3bb9c
feat(cli): register cn config command in main CLI
aaronlippold f0a44cb
docs(cli): add cn config command documentation
aaronlippold 38b10bc
fix(cli): make config tests cross-platform for Windows
aaronlippold 4609b83
fix(cli): fix flaky tests across Windows/Mac CI
aaronlippold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,13 +55,8 @@ export class CLIPlatformClient implements PlatformClient { | |
| } | ||
|
|
||
| private findSecretInLocalEnvFiles(fqsn: FQSN): SecretResult | undefined { | ||
| // First check process.env (highest priority) | ||
| const processEnvSecret = this.findSecretInProcessEnv(fqsn); | ||
| if (processEnvSecret) { | ||
| return processEnvSecret; | ||
| } | ||
|
|
||
| // Then check in priority order: ~/.continue/.env, <workspace>/.continue/.env, <workspace>/.env | ||
| // Check .env files FIRST (highest priority), matching IDE behavior | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| // Priority order: ~/.continue/.env, <workspace>/.continue/.env, <workspace>/.env | ||
| const workspaceDir = process.cwd(); | ||
| const envPaths = [ | ||
| path.join(env.continueHome, ".env"), | ||
|
|
@@ -84,6 +79,12 @@ export class CLIPlatformClient implements PlatformClient { | |
| } | ||
| } | ||
|
|
||
| // Fall back to process.env if not found in .env files | ||
| const processEnvSecret = this.findSecretInProcessEnv(fqsn); | ||
| if (processEnvSecret) { | ||
| return processEnvSecret; | ||
| } | ||
|
|
||
| return undefined; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove this test, see other comment