fix: general maintenance, updates, and linter fixes#712
Open
06kellyjac wants to merge 7 commits intomasterfrom
Open
fix: general maintenance, updates, and linter fixes#71206kellyjac wants to merge 7 commits intomasterfrom
06kellyjac wants to merge 7 commits intomasterfrom
Conversation
Migrate from github.com/ghodss/yaml to sigs.k8s.io/yaml Update from gopkg.in/yaml.v2 to gopkg.in/yaml.v3
esticansat
reviewed
Nov 14, 2025
|
|
||
| if paths != nil && strings.Contains(fmt.Sprintf("%v", paths), "/var/run/docker.sock") { | ||
| found++ | ||
| paths, ok := data.([]interface{}) |
Contributor
There was a problem hiding this comment.
this can be cast to []string instead
esticansat
reviewed
Nov 14, 2025
|
|
||
| if paths != nil { | ||
| found += len(paths.([]interface{})) | ||
| paths, ok := data.([]interface{}) |
Contributor
There was a problem hiding this comment.
need to double check if this can be cast to []string instead
esticansat
reviewed
Nov 14, 2025
| // In wrapping error treat all httpError types as nil-able | ||
| func NewHTTPError(msg string) *httpError { | ||
| return &httpError{ | ||
| statusCode: http.StatusBadRequest, |
Contributor
There was a problem hiding this comment.
this should be internal server error instead
esticansat
requested changes
Nov 14, 2025
Contributor
esticansat
left a comment
esticansat
left a comment
There was a problem hiding this comment.
some comments from review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions.
Code Submissions.
Changes to Core Features.