Skip to content

ht: ignore no insert if value is null #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btovar merged 1 commit into from
Mar 9, 2026
Merged

ht: ignore no insert if value is null #4366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dttools/src/hash_table.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,10 @@ int hash_table_insert(struct hash_table *h, const char *key, const void *value)
* key would be included or skipped in the iteration */
h->cant_iterate_yet = 1;
} else {
/* Should be unreachable but keep for safety. */
notice(D_ERROR, "Failed to insert key %s into hash table.", key);
if (value != NULL) {
/* signal possible memory leak. Only if hash table is being used as set we do not print the message. */
notice(D_ERROR, "Failed to insert key %s into hash table.", key);
}
free(e->key);
free(e);
}
Expand Down