Skip to content

DS-12105 Lock code-input on error#1808

Open
Dan28396 wants to merge 3 commits intomasterfrom
DS-12105-lock-input-on-error
Open

DS-12105 Lock code-input on error#1808
Dan28396 wants to merge 3 commits intomasterfrom
DS-12105-lock-input-on-error

Conversation

@Dan28396
Copy link

@Dan28396 Dan28396 commented Aug 11, 2025

Теперь инпут невозможно изменить в состоянии ошибки до истечения тайм-аута errorVisibleDuration, если clearCodeOnError в значении true

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • К реквесту добавлен changeset
2025-09-22.20.00.34.mov

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: 5ef82f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@alfalab/core-components-code-input Minor
@alfalab/core-components Minor
@alfalab/core-components-confirmation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Dan28396 Dan28396 self-assigned this Aug 11, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16883520335

Details

  • 18 of 21 (85.71%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 79.816%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/code-input/src/components/base-code-input/component.tsx 18 21 85.71%
Files with Coverage Reduction New Missed Lines %
packages/code-input/src/components/base-code-input/component.tsx 4 69.51%
Totals Coverage Status
Change from base Build 16772536302: 0.02%
Covered Lines: 9650
Relevant Lines: 11324

💛 - Coveralls

@github-actions
Copy link
Contributor

Demo build

https://core-ds.github.io/core-components/1808

@dHIM24 dHIM24 requested a review from Oladii September 22, 2025 16:58
@@ -0,0 +1,5 @@
---
'@alfalab/core-components-code-input': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавь дополнительно

'@alfalab/core-components': minor

@fulcanellee
Copy link
Contributor

@Oladii проверь плиз на соответствие спеки

@fulcanellee
Copy link
Contributor

@dHIM24 восстанови плиз этот пр, как свой вольешь #1900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants