feat(skeleton): replace the background animation with opacity#2109
Open
Artem4991 wants to merge 1 commit intocore-ds:masterfrom
Open
feat(skeleton): replace the background animation with opacity#2109Artem4991 wants to merge 1 commit intocore-ds:masterfrom
Artem4991 wants to merge 1 commit intocore-ds:masterfrom
Conversation
Artem4991
requested review from
SiebenSieben,
dHIM24,
fulcanellee and
hextion
as code owners
🦋 Changeset detectedLatest commit: 7828cd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dHIM24
reviewed
Mar 6, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@alfalab/core-components-skeleton': patch | |||
Contributor
There was a problem hiding this comment.
'@alfalab/core-components': patch
Artem4991
force-pushed
the
feat/skeleton-anima-opacity
branch
2 times, most recently
from
3942ce3 to
f7ab746
Compare
Author
|
ребята возникла проблема с скриншотным тестированием, я скрины обновил как в инструкции указанно, и локально ошибок нет, но в ci всегда падает один тест, вы не сталкивались с таким ? FAIL packages/calendar-range/src/Component.screenshots.test.tsx |
Artem4991
force-pushed
the
feat/skeleton-anima-opacity
branch
from
f7ab746 to
29998d5
Compare
Artem4991
force-pushed
the
feat/skeleton-anima-opacity
branch
from
29998d5 to
7828cd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Заменить анимацию skeleton с background на opacity, чем значительно улучшить ее производительность (особенно на мобильных телефонах)
Чек лист
Если есть визуальные изменения