bootupctl: only print the available component when running status in container#1069
Open
HuijingHei wants to merge 1 commit intocoreos:mainfrom
Open
bootupctl: only print the available component when running status in container#1069HuijingHei wants to merge 1 commit intocoreos:mainfrom
HuijingHei wants to merge 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates bootupctl status to only show components with available update metadata when running inside a container. The changes in the Rust code are logical and well-implemented. However, the associated test script in tests/tests/bootupctl-status-in-bootc.sh contains a couple of issues. Specifically, the expected JSON output for the 'no components' scenario is incorrect, and the test case for this scenario lacks assertions, failing to verify the behavior. I've provided detailed comments and suggestions to address these issues in the test script.
HuijingHei
force-pushed
the
fix-status-in-container
branch
4 times, most recently
from
850ed45 to
77d5e28
Compare
in container Skip the component if the update meatadata is missing
HuijingHei
force-pushed
the
fix-status-in-container
branch
from
77d5e28 to
b7c1da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the component if the update meatadata is missing