Configure default head_chunks_write_queue_size#30
Open
friedrichg wants to merge 6 commits intomainfrom
Open
Conversation
…high latency when shipping Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
friedrichg
changed the title
Member
Author
|
some specific tenant had out of order errors/out of bound after midnight. it got fixed when I reverted it. Need to investigate more |
CharlieTLe
previously approved these changes
Jul 21, 2024
Member
CharlieTLe
left a comment
CharlieTLe
left a comment
There was a problem hiding this comment.
Some more info about the flag:
When flag was introduced: cortexproject/cortex#5000
Prometheus Chunks: https://github.com/prometheus/prometheus/blob/1fa9ba838a3b07ba441cda82c3e282ffa866aba6/tsdb/chunks/head_chunks.go#L70-L72
CharlieTLe
approved these changes
Jul 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Configure default head_chunks_write_queue_size to 1 million to avoid high latency when shipping
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]