skip nil values in Memberlist WatchPrefix#7429
Open
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Open
skip nil values in Memberlist WatchPrefix#7429SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a skip in
WatchPrefixwhen a key is deleted, preventing a panic in the HA tracker caused by a failed type assertion on a nil interface value.Related panic log
panic: interface conversion: interface {} is nil, not *ha.ReplicaDesc
goroutine 284 [running]:
github.com/cortexproject/cortex/pkg/ha.(*HATracker).loop.func3({0xc000c68ebb?, 0xc2703e459cea4e8f?}, {0x0?, 0x0?})
/__w/cortex/cortex/pkg/ha/ha_tracker.go:437 +0x629
github.com/cortexproject/cortex/pkg/ring/kv.(*prefixedKVClient).WatchPrefix.func1({0xc000c68eb0?, 0x41?}, {0x0?, 0x0?})
/__w/cortex/cortex/pkg/ring/kv/prefix.go:52 +0xb1
github.com/cortexproject/cortex/pkg/ring/kv/memberlist.(*KV).WatchPrefix(0xc000607808, {0x415fa48, 0xc000708e40}, {0xc000938060, 0xb}, {0x416ee40, 0xc00097f320}, 0xc000bf6090)
/__w/cortex/cortex/pkg/ring/kv/memberlist/memberlist_client.go:841 +0x4c7
github.com/cortexproject/cortex/pkg/ring/kv/memberlist.(*Client).WatchPrefix(0xc00097f338, {0x415fa48, 0xc000708e40}, {0xc000938060, 0xb}, 0xc000bf6090)
/__w/cortex/cortex/pkg/ring/kv/memberlist/memberlist_client.go:113 +0x6a
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags