Added GR and shield veto functionality#114
Added GR and shield veto functionality#114parshadkp wants to merge 9 commits intocositools:develop/emfrom
Conversation
Changed MModuleDEESMEX to set vetoes so that EventSaver ignores the events. Also fixed the veto window size requirement for shield triggers in shield trigger module by setting veto true within the veto window.
Checked shield veto works as expected for low and high energy sources. Removed print statement for m_NumShieldVetoCounts.
Co-authored-by: Felix Hagemann <hagemann@berkeley.edu>
These values are likely to change over time so keep them as values that can be passed in.
Updated code to read m_ShieldVetoWindowSize from deadtime_Parameters.txt file, which can be easily changed. Also addressed Felix's comment in latest commit. |
|
|
||
| //! Get number of strip hits erased | ||
| int GetStripHitsErased() const { return m_StripHitsErased; } | ||
| // int GetStripHitsErased() const { return m_StripHitsErased; } |
There was a problem hiding this comment.
Can you comment on why you removed m_StripHitsErased and all associated functionalities? Will this be dealt with in another (sub)module?
There was a problem hiding this comment.
No other modules uses this and this was only used for the printing at the end of the StripTriggerModule. This was just meant to be a diagnostic printout.
| // // Track which GeD detectors got hit (for later deadtime update) | ||
| // list<MDEEStripHit>& LVHits = Event->GetDEEStripHitLVListReference(); | ||
| // for (const MDEEStripHit& Hit : LVHits) { | ||
| // int DetID = Hit.m_ROE.GetDetectorID(); | ||
| // if (DetID >= 0 && DetID < nDets) { | ||
| // m_DetectorsHitForShieldVeto[DetID] = 1; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Why was this commented? Do you plan on adding it back later (in a modified form)?
There was a problem hiding this comment.
Nope, I will remove this permanently. This was leftover from old balloon code.
Co-authored-by: Felix Hagemann <hagemann@berkeley.edu>
2 participants
GR and shield veto added. Checked response correctness by using a low energy and a high energy Cosima source. May need to update m_ShieldVetoWindowSize in the future.
This will close issue: #95.