Merged
Conversation
* Implement high-performance [LoggerMessage] source generators for Cluster and CouchbaseHttpClientFactory lifecycles. * Update AnalyticsService logs to trace QueryContext to improve multi-tenant request debugging. * Refactor QueryHandle and QueryResultHandle to parse server telemetry dynamically into .ToString() outputs instead of holding raw JSON fields. * Restructure QueryMetrics via backwards-compatible QueryMetricsBase inheritance to organically support async schemas (omitting the ResultCount property).
Collaborator
Author
|
Note the first commit is the work, second one is just a sweep up of warnings |
* Refactor QueryHandle and QueryResultHandle constructors to accept a parsed JsonElement instead of a raw JSON string, removing the unnecessary GetRawText() → JsonDocument.Parse() round-trip. * Add defensive guard for undefined/null JsonElement values. * Introduce TestHandleFactory in the test project to centralise the JsonDocument.Parse boilerplate for test readability.
jeffrymorris
approved these changes
Apr 15, 2026
jeffrymorris
requested changes
Apr 15, 2026
Contributor
jeffrymorris
left a comment
jeffrymorris
left a comment
There was a problem hiding this comment.
Waiting for your changes...lmk
jeffrymorris
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[LoggerMessage]source generatorsfor
ClusterandCouchbaseHttpClientFactorylifecycles.AnalyticsServicelogs to traceQueryContextto improvemulti-tenant request debugging.
QueryHandleandQueryResultHandleto parse servertelemetry dynamically into
.ToString()outputs instead ofholding raw JSON fields.
QueryMetricsvia backwards-compatibleQueryMetricsBaseinheritance to organically support asyncschemas (omitting exactly the
ResultCountproperty).