Move fee policy configuration from CLI args to config file#4158
Move fee policy configuration from CLI args to config file#4158jmg-duarte merged 9 commits intomainfrom
Conversation
a79ed14 to
8a4f648
Compare
8cd5de1 to
a826966
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors fee policy configuration from CLI arguments to a TOML configuration file. The changes are applied across the codebase, including updates to E2E tests. One review comment has been kept regarding a potential logic change in a test, as it does not contradict any established rules.
| /// Describes how the protocol fees should be calculated. | ||
| #[serde(flatten)] | ||
| pub fee_policies_config: FeePoliciesConfig, |
There was a problem hiding this comment.
Doesn't it make sense to not flatten the config here? Config files were related things get grouped together are easier to navigate, no?
In order to avoid weird naming originating from this one could consider naming this field fee_policies and the FeePoliciesConfig::fee_policies could be renamed to initial_policies (as opposed to upcoming_policies.
There was a problem hiding this comment.
unflattened and variables renamed, let me know what you think
Description
Extract FeeFactor from shared::arguments into its own shared::fee_factor module, adding Serialize/Deserialize support
Requires https://github.com/cowprotocol/infrastructure/pull/4620 to be merged before
Changes
How to test
E2E + staging