fix: set ENOENT errno in rmdir(undef)#286
Draft
Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Draft
Conversation
Every other CORE override that handles undef arguments (mkdir, symlink, link, readlink) sets $! before returning, but __rmdir was missing this. Real CORE::rmdir(undef) sets $! to ENOENT — match that behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
__rmdirnow sets$! = ENOENTwhen called with an undefined path argument.Why
Every other CORE override that handles undef arguments (
__mkdir,__symlink,__link,__readlink) properly sets$!before returning 0.__rmdirwas the only one missing this, causing inconsistent errno behavior. RealCORE::rmdir(undef)sets errno to ENOENT.How
One-line fix: added
$! = ENOENT;before thereturn 0in the undef-path guard. Updatedt/rmdir.tto assert the errno value.Testing
$! == ENOENTafterrmdir(undef)🤖 Generated with Claude Code