Skip to content

Fixed NPE when packaging a measure with an unresolvable primary library reference#588

Merged
brynrhodes merged 3 commits intomasterfrom
fixed-npes-with-unresolved-primary-library
Mar 2, 2026
Merged

Fixed NPE when packaging a measure with an unresolvable primary library reference#588
brynrhodes merged 3 commits intomasterfrom
fixed-npes-with-unresolved-primary-library

Conversation

@brynrhodes
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.02%. Comparing base (6d6da43) to head (5513bf5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ava/org/opencds/cqf/tooling/packaging/Package.java 50.00% 1 Missing and 3 partials ⚠️
...encds/cqf/tooling/packaging/r4/PackageMeasure.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
+ Coverage     20.01%   20.02%   +0.01%     
  Complexity     1672     1672              
============================================
  Files           311      311              
  Lines         27390    27395       +5     
  Branches       4340     4344       +4     
============================================
+ Hits           5482     5486       +4     
+ Misses        20989    20986       -3     
- Partials        919      923       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raleigh-g-thompson raleigh-g-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the code in the resolvePrimaryLibraryDependencies function works as expected, but not clear from the code the exact intent of this logic with regards to the local primaryLibrary and the instance's primaryLibrary value.

Copy link
Contributor

@raleigh-g-thompson raleigh-g-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed implementation with Bryn and will accept current changes.

@brynrhodes brynrhodes merged commit aaf9753 into master Mar 2, 2026
4 checks passed
@brynrhodes brynrhodes deleted the fixed-npes-with-unresolved-primary-library branch March 2, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants