Open
Conversation
According to the UCUM spec:
> The full range of characters 33–126 can be used within a pair of curly braces (‘{’ and ‘}’).
This means that the custom unit `{eskimo kisses}` is technically invalid (since the space character is not in the valid range). Replace the space with an underscore (_), which is allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the UCUM specification:
This means that the custom unit
{eskimo kisses}is technically invalid (since the space character is not in the valid range). This PR replaces the space with an underscore (_) since_is allowed. Without this change, engines that enforce UCUM units will fail this test.Note that the
ucum-lhclibrary started enforcing this about three years ago (in ucum-lhc v4.1.8).