BLASTBufferQueue: Add epoll_pwait2 fallback for older kernels #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlinking death recipients (from linkToDeath) is a normal part of Binder operation, and doing it when a BpBinder's refcount has reached 0 is not much different. This log message is constantly spamming when swiping as part of a back navigation gesture: 04-05 22:29:41.402 655 3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor> 04-05 22:29:41.413 655 3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor> 04-05 22:29:41.424 655 3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor> 04-05 22:29:41.435 655 681 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor> 04-05 22:29:41.447 655 3888 I BpBinder: onLastStrongRef automatically unlinking death recipients: <uncached descriptor> Logging is relatively expensive on Android and the log spam isn't useful, so suppress this log message by setting it to the verbose log level. Change-Id: I774d0c59ca6f70a4e2ed33b9fac3fb5b86d8ff0a Signed-off-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Hưng Phan <phandinhhungvp2001@gmail.com> Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
- Miui Camera requires it E CAM_MiCamAlgoInterfaceJNI: can not load library:camera_algoup_jni.xiaomi : java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "_ZN7android18BnProducerListener16onBufferDetachedEi" referenced by "/system/lib64/libcamera_algoup_jni.xiaomi.so"... Change-Id: If79a0a75d02ab87e38e6122520964c0d9c3e63d5 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
When `listenerStatsToSend` in `TransactionCallbackInvoker::sendCallbacks` is empty, simply return to avoid the redundant thread scheduling overhead caused by `BackgroundExecutor::getInstance()`. Change-Id: I00a717933406b2580e5d28daca28e94f0b80f9c8 Signed-off-by: Liangliang Sui <coolsui.coding@gmail.com>
[Pulkit077]: Adapt to A14 QPR1 [SamarV-121]: Adapt to A14 QPR3 Taken from CLO (QSSI 13). Some Qualcomm devices can still benefit from disabling backpressure propagation by setting: debug.sf.disable_backpressure=1 Change-Id: I669a6059a2a971aa79603e74153fa93729f703dc Signed-off-by: Pulkit077 <pulkitagarwal2k1@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
partially reverts: 1fd9bfc Signed-off-by: minaripenguin <minaripenguin@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
In streaming video case, video decoder needs to change buffer color space dynamically according to video stream real-time parameters. CRs-Fixed: 3155775 Change-Id: I21590ee41708f5cb1ed45cb5a7f5c00f1c129bb0 Signed-off-by: tejas101k <tejassingh649@rediffmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
The epoll_pwait2 syscall was introduced in Linux 5.11. Older kernels return ENOSYS when attempting to use this syscall, causing buffer release operations to fail. 12-07 18:05:15.668 2095 2226 E BLASTBufferQueue: epoll_wait error while waiting for buffer release. errno=38 message='Function not implemented' 12-07 18:05:15.668 2095 2226 E BLASTBufferQueue: epoll_wait error while waiting for buffer release. errno=38 message='Function not implemented' Test: Boot device with kernel < 5.11, verify no epoll errors Signed-off-by: Dmitrii <bankersenator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The epoll_pwait2 syscall was introduced in Linux 5.11. Older kernels return ENOSYS when attempting to use this syscall, causing buffer release operations to fail.
12-07 18:05:15.668 2095 2226 E BLASTBufferQueue: epoll_wait error while waiting for buffer release. errno=38 message='Function not implemented'
12-07 18:05:15.668 2095 2226 E BLASTBufferQueue: epoll_wait error while waiting for buffer release. errno=38 message='Function not implemented'
Test: Boot device with kernel < 5.11, verify no epoll errors