Skip to content

GameSpace: Fix the crash issue when incomingNumber was empty #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pzqqt wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+3 −3
Open

GameSpace: Fix the crash issue when incomingNumber was empty #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/java/io/chaldeaprjkt/gamespace/gamebar/CallListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class CallListener @Inject constructor(
private val phoneStateListener = object: PhoneStateListener() {
override fun onCallStateChanged(state: Int, incomingNumber: String?) {
if (state == TelephonyManager.CALL_STATE_RINGING && callOverlayEnabled) {
showRingerOverlay(incomingNumber ?: "")
showRingerOverlay(incomingNumber)
}
}
}
Expand Down Expand Up @@ -172,7 +172,7 @@ class CallListener @Inject constructor(
}
}

private fun showRingerOverlay(incomingNumber: String) {
private fun showRingerOverlay(incomingNumber: String?) {
if (isOverlayShowing) return

val sidebarX = appSettings.x
Expand All @@ -195,7 +195,7 @@ class CallListener @Inject constructor(
y = appSettings.y - 71.extDp
}

val callerPhoto = loadContactPhoto(context, incomingNumber)
val callerPhoto = if (incomingNumber.isNullOrEmpty()) null else loadContactPhoto(context, incomingNumber)

ringerOverlay = ComposeView(context).apply {
repeatWhenAttached {
Expand Down