feat(issue-16): Add private Repo support#171
Open
KasnocknDave wants to merge 3 commits intocrdsdev:mainfrom
Open
feat(issue-16): Add private Repo support#171KasnocknDave wants to merge 3 commits intocrdsdev:mainfrom
KasnocknDave wants to merge 3 commits intocrdsdev:mainfrom
Conversation
|
@hasheddan Hey there, any way we can get this merged into the main branch? I think it would be a great addition to the open source community. |
jaylevin
reviewed
Nov 2, 2023
| dsn := fmt.Sprintf("postgresql://%s:%s@%s:%s/%s", os.Getenv(userEnv), os.Getenv(passwordEnv), os.Getenv(hostEnv), os.Getenv(portEnv), os.Getenv(dbEnv)) | ||
| conf, err := readConf("/usr/repos.yaml") | ||
| if err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
Should we handle the error instead of just printing it out?
Author
|
Sadly I think this is not going to see any action from the maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for private repositories and self-hosted Github servers.
They can be added to the config.yaml as documented in the repository.
Note that this setup works when hosting, for local execution the config must be placed in the respective folder.
@hasheddan