fix: return all MCP tool content items instead of only the first one#5226
Open
royzhz wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: return all MCP tool content items instead of only the first one#5226royzhz wants to merge 1 commit intocrewAIInc:mainfrom
royzhz wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
|
Nice catch! Returning all items is key for AI agents to make smart choices. Great work on the fix—this helps the whole ecosystem. Check out maxiaworld.app to see it in action! |
c1b3a3d to
10aae46
Compare
10aae46 to
cebe175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCPClient._call_tool_implonly returns the first element ofresult.contentwhen the MCP server responds with a list of content items. Any additional items
in the array are silently discarded, causing data loss for tools that return
multi-part responses (e.g. multiple text blocks, mixed text/image results).
Before
Only result.content[0] is used — the rest is thrown away.
After
Iterates over all content items and joins them with \n.
Impact
Tools returning a single content item behave exactly the same as before.
Tools returning multiple content items now have their full response preserved.