fix: make native tool calls async in async execution path to avoid bl…#5227
Open
royzhz wants to merge 3 commits intocrewAIInc:mainfrom
Open
fix: make native tool calls async in async execution path to avoid bl…#5227royzhz wants to merge 3 commits intocrewAIInc:mainfrom
royzhz wants to merge 3 commits intocrewAIInc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_handle_native_tool_callsis synchronous and usesThreadPoolExecutorfor parallel tool execution. When called from the async path (_ainvoke_loop_native_tools), it blocks the event loop, causing the entire program to hang during tool execution.Solution
Added async counterparts for the two key methods:
_ahandle_native_tool_calls— replacesThreadPoolExecutor+as_completedwithasyncio.gatherfor parallel tool execution._aexecute_single_native_tool_call— triesoriginal_tool.arun()first for true async execution; falls back toasyncio.to_thread(tool.run)if the tool hasn't implemented_arun, so the event loop is never blocked.Updated
_ainvoke_loop_native_toolsto callawait self._ahandle_native_tool_calls(). The sync path (_invoke_loop_native_tools) is unchanged.Backward Compatibility
_arunautomatically fall back to thread-based execution viaasyncio.to_thread— no changes required from tool authors._arunget true async execution with no thread overhead.