Skip to content

fix: correct log level and remove redundant warning prefixes#5260

Open
Ricardo-M-L wants to merge 1 commit intocrewAIInc:mainfrom
Ricardo-M-L:fix/logging-message-consistency
Open

fix: correct log level and remove redundant warning prefixes#5260
Ricardo-M-L wants to merge 1 commit intocrewAIInc:mainfrom
Ricardo-M-L:fix/logging-message-consistency

Conversation

@Ricardo-M-L
Copy link
Copy Markdown

@Ricardo-M-L Ricardo-M-L commented Apr 3, 2026

Summary

  • Change logger.error to logger.warning for cleanup errors in trace_batch_manager (cleanup is best-effort, and the message was prefixed with "Warning:" contradicting error level)
  • Remove redundant Warning: prefix from warnings.warn() call in testing.py — warnings.warn already renders as UserWarning: ..., producing double-warning output

Test plan

  • Verify log output is clean and consistent

🤖 Generated with Claude Code


Note

Low Risk
Low risk: only adjusts log/warning messaging (no behavior or data flow changes), aside from reduced severity of a cleanup failure log line.

Overview
Tones down trace batch cleanup failure reporting by logging _cleanup_batch_data exceptions as warning instead of error.

Cleans up evaluation output by removing the redundant "Warning:" prefix from assert_experiment_no_regression’s warnings.warn message so warnings aren’t double-prefixed.

Written by Cursor Bugbot for commit e648951. This will update automatically on new commits. Configure here.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant