fix: remove erroneous $ in BrightData SERP search URL f-strings#5271
Open
MilesQLi wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: remove erroneous $ in BrightData SERP search URL f-strings#5271MilesQLi wants to merge 1 commit intocrewAIInc:mainfrom
MilesQLi wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
The get_search_url method used JavaScript template literal syntax
(${query}) instead of Python f-string syntax ({query}), causing
every search query to be prepended with a literal '$' character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5269
The
get_search_url()method inBrightDataSearchToolwas using JavaScript template literal syntax (${query}) instead of Python f-string syntax ({query}). This caused every search URL to contain a literal$before the query string, e.g.?q=$testinstead of?q=test.All three search engine paths (Google, Bing, Yandex) had the same issue.
Changes
$prefix from all three f-string interpolations inget_search_url()(lines 134, 136, 137 ofbrightdata_serp.py)That's it — three characters removed. No behavioral changes beyond fixing the URLs.
Test plan
${...}patterns exist in the BrightData tool files