Skip to content

fix(examples): Request ssn scope when using cprNumberIdentifier#302

Merged
janmeier merged 1 commit intomasterfrom
fix-evidencevalidation-ssn
Mar 17, 2026
Merged

fix(examples): Request ssn scope when using cprNumberIdentifier#302
janmeier merged 1 commit intomasterfrom
fix-evidencevalidation-ssn

Conversation

@janmeier
Copy link
Collaborator

See https://iduracommunity.slack.com/archives/C03LEKXA19N/p1773395603490979

I haven't updated the raw graphql examples, since our example component only allows one query, and this requires changes in both create signature order, and add signatory.

@janmeier janmeier requested a review from mickhansen March 13, 2026 11:22
@netlify
Copy link

netlify bot commented Mar 13, 2026

Deploy Preview for criipto-docs ready!

Name Link
🔨 Latest commit c54f3d0
🔍 Latest deploy log https://app.netlify.com/projects/criipto-docs/deploys/69b945791038a0000894b34a
😎 Deploy Preview https://deploy-preview-302--criipto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mickhansen
Copy link
Collaborator

this requires changes in both create signature order, and add signatory.

addSignatory changes should be sufficient actually.


var evidenceProviders = new List<EvidenceProviderInput>() {
new EvidenceProviderInput {
criiptoVerify = new CriiptoVerifyProviderInput() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit odd to add to the "basic" example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - Should we rather remove the evidence validation from the example?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds good

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmeier janmeier requested a review from mickhansen March 17, 2026 10:19
@janmeier janmeier force-pushed the fix-evidencevalidation-ssn branch from fff60a0 to 63c8541 Compare March 17, 2026 12:03
@janmeier janmeier force-pushed the fix-evidencevalidation-ssn branch from 63c8541 to c54f3d0 Compare March 17, 2026 12:13
@janmeier janmeier merged commit 3c7a7a0 into master Mar 17, 2026
5 checks passed
@janmeier janmeier deleted the fix-evidencevalidation-ssn branch March 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants