Merged
Conversation
Contributor
bavulapati
commented
Dec 26, 2025
bavulapati
commented
- Use version agnostic homebrew prefix
- Recent versions of v8 requires C++ 20
- Accept V8 backend as option from make
- Export compile commands from cmake
- Use version agnostic homebrew prefix - Recent versions of v8 requires C++ 20 - Accept V8 backend as option from make - Export compile commands from cmake - Update libjavascriptcoregtk to 4.1-dev, as ubuntu got updated Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
force-pushed
the
use-version-agnostic-v8-prefix
branch
from
e4da552 to
0f96bd1
Compare
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
commented
Dec 26, 2025
jviotti
approved these changes
Dec 26, 2025
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.