Expose composite resource ready state in function response#496
Merged
bobh66 merged 7 commits intocrossplane-contrib:mainfrom Mar 4, 2026
Merged
Conversation
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
tenitski
requested review from
bobh66,
negz,
sergenyalcin and
turkenf
as code owners
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
2 tasks
Contributor
Author
|
@bobh66 now after |
Collaborator
|
Thanks @tenitski - can you give a few more details on what's changing? It seems like a lot of code changes that are unrelated to the composite readiness. It appears to have something to do with merging status updates? Thanks |
Contributor
Author
|
@bobh66 i've updated the PR description to clarify the changes |
Contributor
Author
|
Still looking forward to have this PR reviewed and merged. We have been running this code in production for over six months now. |
Contributor
Author
|
@bobh66 👋 |
Signed-off-by: Alexei Tenitski <atenitski@adobe.com>
Contributor
Author
|
@bobh66 I fixed lint & unit test, I still see one lint error but it exists in |
Contributor
Author
|
Yay all green |
bobh66
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Allows to set composite resource Ready state via annotation
gotemplating.fn.crossplane.io/ready, similarly how this is done for composed resources.This PR introduces a new usage scenario for unnamed composite resources. Previously, it was used only for passing
Status; now, it also supports passing thegotemplating.fn.crossplane.io/readyannotation.The additional change in this PR is that if
Statusis empty and a resource was used solely to pass the annotation, we will not set an emptyStatusvalue. Before it was not a problem becauseStatuswas always there.Fixes #153
I have: