Fix endless recursion when traversing recursive types.#48
Open
jake-volvo wants to merge 1 commit intocrossplane:masterfrom
Open
Fix endless recursion when traversing recursive types.#48jake-volvo wants to merge 1 commit intocrossplane:masterfrom
jake-volvo wants to merge 1 commit intocrossplane:masterfrom
Conversation
jake-volvo
force-pushed
the
fix-traverse-recursion
branch
from
6958461 to
784703f
Compare
Simply keep a slice of already visited types and exit early. Fixes crossplane#47 Signed-off-by: Jakub Ciolek <jakub@ciolek.dev>
jake-volvo
force-pushed
the
fix-traverse-recursion
branch
from
784703f to
3997423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply keep a slice of already visited types and exit early.
Fixes #47
Signed-off-by: jakub@ciolek.dev