[4.0]neutron[Cisco_ACI]: Backport from #1548#1549
Closed
vvaradhan wants to merge 1 commit intocrowbar:stable/4.0from
Closed
[4.0]neutron[Cisco_ACI]: Backport from #1548#1549vvaradhan wants to merge 1 commit intocrowbar:stable/4.0from
vvaradhan wants to merge 1 commit intocrowbar:stable/4.0from
Conversation
dirkmueller
requested changes
Mar 16, 2018
Contributor
dirkmueller
left a comment
There was a problem hiding this comment.
please add a migration for the proposal data schema change.
Contributor
|
Changes taken care of in #2228 on updated base and changes for latest ACI firmware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the following feature for Cisco ACI:
Allows Crowbar configuration for enabling multiple VMM domain features for ACI. It was painful for the customer to change in the config file manually and avoid the chef-client from overriding the config. Both KVM and VMWare based VMM domains can be configured using this feature.
Each [apic_vmdom:<vmm_domain_name>] corresponds to a VMM configuration. In these sections, [apic] configurations can be overridden for more granular infrastructure sharing.
What is configured in the [apic] sharing will be the default used in case a more specific configuration is missing for the domain.
For example:
[apic_vmdom:soc_kvm_domain]
vlan_ranges=1000:2000
[apic_vmdom:soc_vmware_domain]
apic_vmm_type=vmware
enable_optimized_dhcp=false
enable_optimized_metadata=false
In case of a VMWare based VMM domain, the respective VMM domain MUST be created in APIC prior to configuring in neutron. For KVM, neutron will create the VMM domain if not already created.
Note: The intended target of this PR is Cloud 7 and is updated here due to the standard process being followed for all PRs (master-update followed by cloud 7 backport). The tests were only done for Cloud 7 based deployments.