Merged
Conversation
blotus
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Go toolchain version used by the waf-check module and the appsec rules CI workflow to keep them aligned.
Changes:
- Bump
waf-checkmodulegoversion from 1.25 to 1.26. - Update
test_appsec_rulesGitHub Actions workflow to use Go 1.26.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
waf-check/go.mod |
Raises the module’s minimum Go version to 1.26. |
.github/workflows/test_appsec_rules.yaml |
Aligns CI’s setup-go version with the updated Go version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0 | ||
| with: | ||
| go-version: '1.25' | ||
| go-version: '1.26' |
There was a problem hiding this comment.
actions/setup-go hardcodes the Go version here, while other workflows (e.g. .github/workflows/lint.yml) use go-version-file: waf-check/go.mod. Consider switching this step to go-version-file (or a shared GO_VERSION env var) to reduce the chance of workflows drifting out of sync again.
Suggested change
| go-version: '1.26' | |
| go-version-file: waf-check/go.mod |
blotus
pushed a commit
that referenced
this pull request
Apr 16, 2026
* gni * go mod * again * ci * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist