Problem: sdk 0.52 is not used#568
Closed
mmsqe wants to merge 85 commits intocrypto-org-chain:developfrom
Closed
Conversation
checked in StringToBytes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| gasBz := sdk.Uint64ToBigEndian(gas) | ||
| store.Set(types.KeyPrefixBlockGasWanted, gasBz) | ||
| if err := k.KVStoreService.OpenKVStore(ctx).Set(types.KeyPrefixBlockGasWanted, gasBz); err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
- Coverage 46.17% 46.06% -0.12%
===========================================
Files 181 181
Lines 18153 18253 +100
===========================================
+ Hits 8383 8408 +25
- Misses 9050 9110 +60
- Partials 720 735 +15
🚀 New features to boost your workflow:
|
Comment on lines
+976
to
+978
| for addr := range GetMaccPerms() { | ||
| result[addr] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
mmsqe
commented
Jan 8, 2025
12 tasks
|
Close PR due to the develop branch has integrated with SDK v0.53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)