Skip to content

Update block-ciphers.rst#380

Open
nktrejo2020 wants to merge 1 commit intocrypto101:masterfrom
nktrejo2020:patch-4
Open

Update block-ciphers.rst#380
nktrejo2020 wants to merge 1 commit intocrypto101:masterfrom
nktrejo2020:patch-4

Conversation

@nktrejo2020
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/block-ciphers.rst
:from_template: advanced

AES consists of several independent steps. At a high level, AES is a
AES includes several independent steps. At a high level, AES is a
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't include imply that there may be other parts too?

Comment thread src/block-ciphers.rst

AES requires separate keys for each round in the next steps. The key
schedule is the process which AES uses to derive 128-bit keys for each
The next steps show how AES requires separate keys for each round. In the key
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the meaning of the sentence. It's saying AWS consists of several steps (see before), and future steps require round keys, and this step is about generating those round keys. It does not show how AES "requires" round keys, it shows how AES produces them.

Comment thread src/block-ciphers.rst

SubBytes is the step that applies the S-box (substitution box) in AES.
The S-box itself substitutes a byte with another byte, and this S-box is
The AES SubBytes step applies to the S-box (substitution box).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the meaning of the sentence to be incorrect. SubBytes applies the S-box. It does not apply to the S-box. SubBytes is itself an application of the S-box.

Comment thread src/block-ciphers.rst
In an effort to extend the life of the DES algorithm, in a way that
allowed much of the spent hardware development effort to be reused,
people came up with 3DES: a scheme where input is first encrypted, then
In efforts to extend the DES algorithm life in that
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear to be grammatical.

Comment thread src/block-ciphers.rst
brute-force becomes impractical.

The three keys could all be chosen independently (yielding 168 key
The three keys can be chosen independently (yielding 168 key
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread src/block-ciphers.rst
the first encryption, so you really only get the effect of the last
encryption. This is intended as a backwards compatibility mode for
the first encryption. You really only get the effect of the last
encryption. It is intended as a backwards compatibility mode for
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread src/block-ciphers.rst
3DES implementations for systems that require DES compatibility.
This is particularly important for hardware implementations because
providing a secondary, regular “single DES”
interface next to the primary 3DES interface is not always possible.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread src/block-ciphers.rst
interface next to the primary 3DES interface is not always possible.

Some attacks on 3DES are known, reducing their effective security. While
Some attacks on 3DES are known, which reduces their effective security. While
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread src/block-ciphers.rst
3DES is a poor choice for any modern cryptosystem. The security margin
is already small, and continues to shrink as cryptographic attacks
3DES is a poor choice for a modern cryptosystem. The security margin
is small and continues to shrink as cryptographic attacks
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread src/block-ciphers.rst
more secure than 3DES, they are also generally much, much faster. On the
same hardware and in the same :term:`mode of operation` (we'll explain what that
means in the next chapter), AES-128 only takes 12.6 cycles per byte,
Far better alternatives, such as AES, are available. AES are
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not grammatical: AES is singular.

Comment thread src/block-ciphers.rst
:cite:`cryptopp:bench` Despite being worse from a security
point of view, it is literally an order of magnitude slower.
:cite:`cryptopp:bench` Despite being risker from a security
perspective, 3DES are literally an order of magnitude slower.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not grammatical: 3DES is singular.

Comment thread src/block-ciphers.rst
While more iterations of DES might increase the security margin, they
aren't used in practice. First of all, the process has never been
standardized beyond three iterations. Also, the performance only becomes
While more DES iterations can increase the security margin, they
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not known if more iterations increase the security margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants