fix native compiler class field initializers, add boolean[] tests#491
Merged
fix native compiler class field initializers, add boolean[] tests#491
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
…, fix getAllFields to avoid as ClassField on pushed elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class Foo { x: number = 42; }now works when compiled by the native compiler. Previously, field initializers were silently ignored, leaving fields at zero/null defaults.classFields[fi]from an ObjectArray lost itsClassFieldtype info in the native compiler, socf.initializerread field index 0 (name) instead of index 3 (initializer). Fixed by addingas ClassFieldtype assertions on ObjectArray element access.class-field-inittest — instance field initializers now pass with native compilerswitch-string-topleveltest — top-level string switch works correctlyboolean[]support (literals, push, index assignment, prime sieve)Test plan
npm run verify:quickpasses (tests + self-hosting Stage 1)class-field-init.tspasses with native compiler (previously skipped)switch-string-toplevel.tspasses with native compiler (previously skipped)