MOLE.jl: Refactoring in Opearors and BCs Modules#282
MOLE.jl: Refactoring in Opearors and BCs Modules#282valeriabarra wants to merge 1 commit intomainfrom
Conversation
|
Hi @valeriabarra , thanks for this refactoring suggestion! I agree with your changes, and I think this will help keep the code more organized. One comment: currently, with the changes as-is, the "elliptic1D.jl" file won't run, specifically because the
which means that we would need to explicitly call What is the standard practice? Should we require that the module name be called before the function, or should we keep the export statement? Thank you. |
What type of PR is this? (check all applicable)
Description
This PR refactors the current MOLE.jl into (sub)Modules. In the existing version, only the superModule MOLE existed and all operators and boundary condition implementation files were homed all in the same
MOLE.jl/src/directory.Operatorsand one forBCs).MOLE.jl/src/andMOLE.jl/test/subdirectories.MOLE.jl/test/runtests.jlfileRelated Issues & Documents
Added/updated tests?
have not been included
Read Contributing Guide and Code of Conduct