fix(api-gateway): cache GraphQL schemas per security context using visibilityMaskHash#10570
Open
igorlukanin wants to merge 6 commits intomasterfrom
Open
Conversation
f751af6 to
7d39e77
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10570 +/- ##
==========================================
- Coverage 57.79% 57.78% -0.02%
==========================================
Files 224 224
Lines 17547 17557 +10
Branches 3609 3613 +4
==========================================
+ Hits 10142 10145 +3
- Misses 6861 6867 +6
- Partials 544 545 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6fb5c56 to
2cb33a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
GraphQL schema was cached globally, but different users have different field permissions (RBAC).
First user's schema got cached → all subsequent users saw that same schema with wrong fields.
Fix: Cache schemas per visibilityMaskHash - each unique permission set gets its own cached schema.