Manual cli tool name mode for local/from PR plugin install scripts#3093
Closed
rinOfTheStars wants to merge 1 commit intocursorless-dev:mainfrom
Closed
Manual cli tool name mode for local/from PR plugin install scripts#3093rinOfTheStars wants to merge 1 commit intocursorless-dev:mainfrom
rinOfTheStars wants to merge 1 commit intocursorless-dev:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to manually define the IDE cli tool name to
./packages/cursorless-vscode/scripts/install-from-pr.sh,[...]/install-local.sh, and[...]/uninstall-local.sh, and updates./packages/cursorless-org-docs/src/docs/contributing/CONTRIBUTING.mdxto reflect these changes.Soft-blocks #3092 since I use VSCodium and can't (un)install a local plugin version without this fix.
This requires changing
set -euo pipefailtoset -eo pipefailat the start of all three scripts, which might have unforeseen consequences I can't think of right now; I'm also certain there's a better way to demarcate an argument as being optional than how I did it ininstall-from-pr.shbut IDK what that would be, so feel free to change it to something less garbage!