Added examples of good scope fixtures to docs#3244
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee01dbbf84
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // argumentList.formal.multiLine | ||
| // argument.formal.multiLine |
There was a problem hiding this comment.
Don’t present function-level formal scopes as Java fixtures
In this java example block, argumentList.formal.multiLine and argument.formal.multiLine look like the recommended Java names, but packages/lib-common/src/scopeSupportFacets/java.ts:249-257 marks those function-level facets as notApplicable. The Java fixtures in resources/fixtures/scopes/java/argumentList/argumentList.formal.method.multiLine.scope:1-6 use the .method.multiLine variants instead, so this sample currently teaches Java contributors a scope combination they cannot actually generate.
Useful? React with 👍 / 👎.
No description provided.