Skip to content

Added examples of good scope fixtures to docs#3244

Merged
AndreasArvidsson merged 1 commit intomainfrom
scopeExamples
Mar 21, 2026
Merged

Added examples of good scope fixtures to docs#3244
AndreasArvidsson merged 1 commit intomainfrom
scopeExamples

Conversation

@AndreasArvidsson
Copy link
Member

No description provided.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner March 21, 2026 14:10
@AndreasArvidsson AndreasArvidsson merged commit 80fc519 into main Mar 21, 2026
16 checks passed
@AndreasArvidsson AndreasArvidsson deleted the scopeExamples branch March 21, 2026 14:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee01dbbf84

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +165 to +166
// argumentList.formal.multiLine
// argument.formal.multiLine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don’t present function-level formal scopes as Java fixtures

In this java example block, argumentList.formal.multiLine and argument.formal.multiLine look like the recommended Java names, but packages/lib-common/src/scopeSupportFacets/java.ts:249-257 marks those function-level facets as notApplicable. The Java fixtures in resources/fixtures/scopes/java/argumentList/argumentList.formal.method.multiLine.scope:1-6 use the .method.multiLine variants instead, so this sample currently teaches Java contributors a scope combination they cannot actually generate.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant