Replace eslint and prettier with oxlint and oxfmt#3250
Replace eslint and prettier with oxlint and oxfmt#3250AndreasArvidsson merged 13 commits intomainfrom
Conversation
AndreasArvidsson
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e7e99c774
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3a3b66e34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AndreasArvidsson
requested review from
fidgetingbits and
saidelike
as code owners
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2732029211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| language: system | ||
| entry: pnpm exec eslint | ||
| entry: pnpm exec oxlint | ||
| args: [--fix] |
There was a problem hiding this comment.
The new hook runs oxlint with only --fix, but the repository rule set is configured almost entirely at warning level ("warn" in .oxlintrc.json). Per Oxlint CLI docs, warnings only trigger a non-zero exit with --deny-warnings, so this hook will pass with unresolved lint violations that then fail later in CI (lint:ts uses oxlint --deny-warnings .). This regresses local guardrails by allowing commits that pre-commit should have blocked.
Useful? React with 👍 / 👎.
1 participant
No description provided.