Replace dCache's 'DirectoryStream' with Java's 'DirectoryStream'#7262
Open
LukasMansour wants to merge 7 commits intodCache:masterfrom
Open
Replace dCache's 'DirectoryStream' with Java's 'DirectoryStream'#7262LukasMansour wants to merge 7 commits intodCache:masterfrom
LukasMansour wants to merge 7 commits intodCache:masterfrom
Conversation
Signed-off-by: Lukas R. Mansour <lukas.mansour@desy.de>
LukasMansour
changed the title
# Conflicts: # modules/dcache-bulk/src/main/java/org/dcache/services/bulk/job/AbstractRequestContainerJob.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Closes #3821
Modification:
Replaces dCache's old 'DirectoryStream' with Java's 'DirectoryStream'.
Removing dCache's old
DirectoryStreamresults in some emptyIOExceptioncatch-blocks that shouldn't be throwable...Result:
The returned Streams of
DirectoryEntryare now always a type of JDK's NIODirectoryStream<DirectoryEntry>, dCache's customDirectoryStreamis removed. There are some empty (throw RuntimeException) blocks forIOExceptions that are not throwable. They appear since the JDK InterfaceClosabledefines aclose()-method with anIOExceptionThrowable. andDirectoryStreaminherits from Closable.Signed-off-by: Lukas Mansour lukas.mansour@desy.de