Open
Conversation
Contributor
Author
|
Many tests are failing still. Working on it. |
0x7f
commented
Aug 13, 2017
| else if (left.size() == right.size()) | ||
| { | ||
| #ifdef WIN32 | ||
| # define strncasecmp(x, y, z) _strnicmp(x, y, z) |
Contributor
Author
There was a problem hiding this comment.
@daedric what about introducing a utils header which includes this define or is it ok to have it multiple times all over the place?
Contributor
Author
|
The Ragel parser seems to be the problem. When using the stream parser, only 3 tests fail: For
And Will continue investigating later. At least the examples are working :) |
Contributor
Author
Owner
|
Hi @0x7f, Thanks a lot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This patch makes httpp compile on Windows 10 with Visual Studio 2017 Community edition (VC 14.0).
The according commonpp patch can be found here daedric/commonpp#7. The same issue about static linking of TBB and HWLOC applies to this as well.