Skip to content

fix(shared): prevent mobile comment modal overflow#5818

Open
rebelchris wants to merge 2 commits intomainfrom
eng-1169-feedback-bug-report-mobile-commenting-text-issue-background
Open

fix(shared): prevent mobile comment modal overflow#5818
rebelchris wants to merge 2 commits intomainfrom
eng-1169-feedback-bug-report-mobile-commenting-text-issue-background

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented Mar 28, 2026

Summary

  • fix the mobile comment modal background so the scroll surface keeps the modal background color
  • keep the editor and notification switch in normal flex flow to avoid overlap on long comments
  • add a focused regression spec for the mobile comment modal layout

Key decisions

  • removed the viewport-height math and inline height mutation from CommentModal
  • kept the fix scoped to the shared comment modal instead of changing modal infrastructure

Closes ENG-1169


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1169-feedback-bug-report-mob.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 28, 2026 5:36am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 28, 2026 5:36am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant