Change speakers to use the SPacketCustomSound packet instead#578
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
Change speakers to use the SPacketCustomSound packet instead#578SquidDev wants to merge 2 commits intodan200:masterfrom
SquidDev wants to merge 2 commits intodan200:masterfrom
Conversation
The method to register new SoundEvents is private, which means that few (if any) mods actually register them. Consequently, one could not use the speaker to play any modded sound, as they weren't registered on the server side. Using SPacketCustomSound does mean we can no longer determine if a sound exists or not, but I think a price I'm willing to pay in order to allow playing modded sounds.
Contributor
|
What happens if I try to play a sound that doesn't exist? |
Contributor
Author
|
It just returns true and does nothing on the client. |
This restores the previous behaviour.
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…speaker-sound Change speakers to use the SPacketCustomSound packet instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method to register new
SoundEvents is private, which means that few (if any) mods actually register them. Consequently, one could not use the speaker to play any modded sound, as they weren't registered on the server side.Using
SPacketCustomSounddoes mean we can no longer determine if a sound exists or not, but I think a price I'm willing to pay in order to allow playing modded sounds.