Skip to content

Fix test assertions for enhanced move operation error messages#1802

Merged
CodyCBakerPhD merged 4 commits intoenh-lad-errors-pathsfrom
copilot/sub-pr-1792
Feb 14, 2026
Merged

Fix test assertions for enhanced move operation error messages#1802
CodyCBakerPhD merged 4 commits intoenh-lad-errors-pathsfrom
copilot/sub-pr-1792

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

  • Update test_move_file_slash_src to match new error message format
  • Update test_move_file_slash_dest to match new error message format
  • Update test_move_nonexistent_src to match new error message format
  • Update test_move_from_subdir_abspaths to match new error message format
  • Update test_move_from_subdir_as_dot to match new error message format
  • Verify Python syntax of modified files
  • Fix line length linting errors (E501)
  • Commit and push changes
  • Wait for CI tests to pass

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve path validation error messages for move operations Fix test assertions for enhanced move operation error messages Feb 14, 2026
Copilot AI requested a review from CodyCBakerPhD February 14, 2026 05:15
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review February 14, 2026 06:15
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (c89f6af) to head (750ddfa).
⚠️ Report is 26 commits behind head on enh-lad-errors-paths.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           enh-lad-errors-paths    #1802       +/-   ##
=========================================================
+ Coverage                 50.45%   75.11%   +24.66%     
=========================================================
  Files                        84       84               
  Lines                     11922    11925        +3     
=========================================================
+ Hits                       6015     8958     +2943     
+ Misses                     5907     2967     -2940     
Flag Coverage Δ
unittests 75.11% <100.00%> (+24.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CodyCBakerPhD
Copy link
Contributor

Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 14, 2026

@copilot Please fix the linting errors: https://github.com/dandi/dandi-cli/actions/runs/22012555381/job/63608992590?pr=1802#step:6:19

Fixed the linting errors. The issue was three lines exceeding the 100-character limit (lines 378, 410, and 436). Refactored by extracting the conditional expressions into variables (asset_type and path_type) and breaking long strings across multiple lines. Changes committed in 750ddfa.

@CodyCBakerPhD CodyCBakerPhD merged commit ee32925 into enh-lad-errors-paths Feb 14, 2026
34 of 35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the copilot/sub-pr-1792 branch February 14, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants