You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR! Sorry it’s taken me a while to get back to you — I’ve been sick, but now I’m better.
I wonder if it wouldn’t make sense just to switch to hashify entirely rather than phf? That would break the API and require a major version bump, but I imagine it wouldn’t cause a problem for most people.
The big issue right now is that cargo msrv is reporting that the MSRV is now 1.74.1, but the errors that older versions are throwing make me think this might be something that could be worked around. I'll dig into it more. (1.74.1 is more than a year old, so maybe just bumping MSRV is the way to go. Just figured I should check if it was something trivial first.)
Yeah. phf provides the Map interface, I may ask hashify authors for something similar or even propose a PR. As well as downgrade the msrv. The source code is trivial, it would be easy.
fix clippy warnings
fix hashify msrv
implement Map interface inside hashify
xamgore
changed the title
Switch to hashify phf, gain extra 20-30% unescape speed-up
WIP: Switch to hashify phf, gain extra 20-30% unescape speed-up
Mar 4, 2025
xamgore
changed the title
WIP: Switch to hashify phf, gain extra 20-30% unescape speed-up
Switch to hashify phf, gain extra 20-30% unescape speed-up
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #82 for details.