Skip to content

Fix #14308 FP nullPointerRedundantCheck with pointer reference parameter (*&) #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −4
Open

Fix #14308 FP nullPointerRedundantCheck with pointer reference parameter (*&) #8197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d784e85
Update reverseanalyzer.cpp
chrchr-github Feb 11, 2026
9295246
Update testnullpointer.cpp
chrchr-github Feb 11, 2026
40f3651
Update testnullpointer.cpp
chrchr-github Feb 11, 2026
650c8ff
Update .selfcheck_suppressions
chrchr-github Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .selfcheck_suppressions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
missingIncludeSystem
# should not be reported - see #13387
checkersReport
# false positive - see #14308
nullPointerRedundantCheck:externals/simplecpp/simplecpp.cpp:3246

# warnings in Qt generated code we cannot fix
funcArgNamesDifferent:*/moc_checkthread.cpp
Expand Down
4 changes: 2 additions & 2 deletions lib/reverseanalyzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,13 +298,13 @@ namespace {
if (!condTok)
break;
Analyzer::Action condAction = analyzeRecursive(condTok);
if (condAction.isModified())
break;
const bool inLoop = Token::Match(condTok->astTop()->previous(), "for|while (");
// Evaluate condition of for and while loops first
if (inLoop) {
if (Token::findmatch(tok->link(), "goto|break", tok))
break;
if (condAction.isModified())
break;
valueFlowGenericForward(condTok, analyzer, tokenlist, errorLogger, settings);
}
Token* thenEnd;
Expand Down
15 changes: 15 additions & 0 deletions test/testnullpointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3787,6 +3787,21 @@ class TestNullPointer : public TestFixture {
" g(x);\n"
"}");
ASSERT_EQUALS("", errout_str());

check("struct T {\n" // #14308
" bool b{};\n"
" T* next{};\n"
"};\n"
"bool g(const T*& r) {\n"
" const T* t = r;\n"
" r = t->next;\n"
" return t->b;\n"
"}\n"
"void f(const T* tok) {\n"
" if (g(tok)) {}\n"
" if (tok) {}\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void nullpointerExit() {
Expand Down
Loading